R82: Errors adding multiple plugin types to family

When you create a new family you can add multiple object plugin types to it if you select and add them all at once. It generates errors, but if you ignore them, it seems to work. I assume that since if you add one object type to the family, all other object types are removed from the lhs, it is not intended for the families to support multiple types. But there is nothing done to prevent adding them all at once.

To reproduce the problem, use the Unique ID (UID) example supplied with C2. Add a family to the project and select the three objects on the lhs and move them all at once to the family. Click OK and then Ignore all of the errors. On the event sheet change the references to Sprite to Family1 and run. It all works as before, except the UIDs are also displayed for the text objects. (Which demonstrates that this could be a cool feature at some later date.)

Here are the errors I received when I clicked OK after adding the objects to the family.

---------------------------

Construct 2 Check failure

---------------------------

Check failure! This is probably a bug:

Adding wrong plugin type to family

Condition: plugin_id_str.empty() || type_->GetPluginID() == plugin_id_str

File: Projects\Family.cpp

Line: 185

Function: void __cdecl Family::AddObjectType(class ObjectType *)

Build: release 82 (64-bit) checked

Component: Construct 2 IDE

(Last Win32 error: 0)

You are using a 'checked' release of Construct 2, intended for testing, which causes certain errors to be reported this way. Hit Ctrl+C to copy this messagebox - it's useful information for the developers, so please include it with any bug reports! Click 'Abort' to quit (unsaved data will be lost!),'Retry' to turn off messages for this session and continue, or 'Ignore' to continue normally.

---------------------------

Abort   Retry   Ignore   

---------------------------

---------------------------

Construct 2 Check failure

---------------------------

Check failure! This is probably a bug:

Family does not have a single plugin type

Condition: AreAllSamePluginType()

File: Projects\Family.cpp

Line: 196

Function: void __cdecl Family::AddObjectType(class ObjectType *)

Build: release 82 (64-bit) checked

Component: Construct 2

(Last Win32 error: 0)

You are using a 'checked' release of Construct 2, intended for testing, which causes certain errors to be reported this way. Hit Ctrl+C to copy this messagebox - it's useful information for the developers, so please include it with any bug reports! Click 'Abort' to quit (unsaved data will be lost!),'Retry' to turn off messages for this session and continue, or 'Ignore' to continue normally.

---------------------------

Abort   Retry   Ignore   

---------------------------

---------------------------

Construct 2 Check failure

---------------------------

Check failure! This is probably a bug:

Adding wrong plugin type to family

Condition: plugin_id_str.empty() || type_->GetPluginID() == plugin_id_str

File: Projects\Family.cpp

Line: 185

Function: void __cdecl Family::AddObjectType(class ObjectType *)

Build: release 82 (64-bit) checked

Component: Construct 2 IDE

(Last Win32 error: 0)

You are using a 'checked' release of Construct 2, intended for testing, which causes certain errors to be reported this way. Hit Ctrl+C to copy this messagebox - it's useful information for the developers, so please include it with any bug reports! Click 'Abort' to quit (unsaved data will be lost!),'Retry' to turn off messages for this session and continue, or 'Ignore' to continue normally.

---------------------------

Abort   Retry   Ignore   

---------------------------

---------------------------

Construct 2 Check failure

---------------------------

Check failure! This is probably a bug:

Family does not have a single plugin type

Condition: AreAllSamePluginType()

File: Projects\Family.cpp

Line: 196

Function: void __cdecl Family::AddObjectType(class ObjectType *)

Build: release 82 (64-bit) checked

Component: Construct 2 IDE

(Last Win32 error: 0)

You are using a 'checked' release of Construct 2, intended for testing, which causes certain errors to be reported this way. Hit Ctrl+C to copy this messagebox - it's useful information for the developers, so please include it with any bug reports! Click 'Abort' to quit (unsaved data will be lost!),'Retry' to turn off messages for this session and continue, or 'Ignore' to continue normally.

---------------------------

Abort   Retry   Ignore   

---------------------------

---------------------------

Construct 2 Check failure

---------------------------

Check failure! This is probably a bug:

Family does not have a single plugin type

Condition: (*i)->AreAllSamePluginType()

File: Bars\ProjectBar - Families.cpp

Line: 30

Function: void __cdecl CProjectBar::AddFamilyFolder(struct _TREEITEM *,class Project *)

Build: release 82 (64-bit) checked

Component: Construct 2 IDE

(Last Win32 error: 0)

You are using a 'checked' release of Construct 2, intended for testing, which causes certain errors to be reported this way. Hit Ctrl+C to copy this messagebox - it's useful information for the developers, so please include it with any bug reports! Click 'Abort' to quit (unsaved data will be lost!),'Retry' to turn off messages for this session and continue, or 'Ignore' to continue normally.

---------------------------

Abort   Retry   Ignore   

---------------------------

---------------------------

Construct 2 Check failure

---------------------------

Check failure! This is probably a bug:

Family does not have a single plugin type

Condition: (*i)->AreAllSamePluginType()

File: Bars\ProjectBar - Families.cpp

Line: 30

Function: void __cdecl CProjectBar::AddFamilyFolder(struct _TREEITEM *,class Project *)

Build: release 82 (64-bit) checked

Component: Construct 2 IDE

(Last Win32 error: 0)

You are using a 'checked' release of Construct 2, intended for testing, which causes certain errors to be reported this way. Hit Ctrl+C to copy this messagebox - it's useful information for the developers, so please include it with any bug reports! Click 'Abort' to quit (unsaved data will be lost!),'Retry' to turn off messages for this session and continue, or 'Ignore' to continue normally.

---------------------------

Abort   Retry   Ignore   

---------------------------

Are the Plugin files decompressed? Just a guess

— Thanks for the input. However, these are standard plugins that ship with C2 -- text and sprite.

I think it is intended for this to not be allowed. There just isn't a check to prevent it at this point. It isn't anything urgent. I was just documenting a problem to be fixed at some time, either by allowing multiple object types or preventing multiple object types.

Thanks for the report, you're right it's intended that this is not allowed. I've added a check to prevent it for the next build, so it should be fixed then.